-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: Back out of axios switchover for the createInstance cloud API request #31486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgriesser
reviewed
Apr 11, 2025
AtofStryker
reviewed
Apr 11, 2025
ef86e0b
to
8e56229
Compare
cypress
|
Project |
cypress
|
Branch Review |
cacie/fix/revert-create-instance-axios
|
Run status |
|
Run duration | 17m 25s |
Commit |
|
Committer | Cacie Prins |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
1
|
|
77
|
|
0
|
|
5624
|
View all changes introduced in this branch ↗︎ |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
tgriesser
approved these changes
Apr 15, 2025
ryanthemanuel
approved these changes
Apr 16, 2025
AtofStryker
approved these changes
Apr 16, 2025
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Axios may need additional configuration to support certain proxy configurations. This switches back to the
@cypress/request
method until that can be addressed. Axios implementation is still included in the codebase, but is not used.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?