`dart analyze` does not know when analyzer plugin results are complete

[derolf]

dartanalyzer version 2.5.0-edge.1ef83b86ae637ffe7359173804cbc6d3fa25e6db

I have a plugin that works fine in the Analysis Server and Analysis notifcations show up in Visual Code.

If I run dartanalyzer ., I don't see notifications.

[bwilkerson]

Unfortunately we have not yet been able to work on getting plugins to work from the command-line analyzer. That work is desired, but not currently scheduled.

[zanderso]

Flutter's CLI users are asking for this to help in running analyzer plugins in their CI. See: flutter/flutter#28327 (comment). /cc @devoncarew.

[bwilkerson]

Actually, they're asking for flutter analyze to run plugins, and my understanding is that flutter analyze uses the analysis server. I don't know why the analysis server is failing to run their plugins when run through flutter analyze, but it's a different issue than this one.

[zanderso]

Ah, sorry about that. I remember now that the issue with the analysis server is that it starts up plugins asynchronously, and the server doesn't give any indication when results from plugins are complete: flutter/flutter#28327 (comment). Guessing that those problems would have to be solved in order to solve this one?

[bwilkerson]

Yes, thanks, that's probably the underlying issue here.

One possible solution would be to add a "command-line" mode for server that causes it to not report diagnostics until all of the plugins have reported results (with safeguards to protect against broken plugins, of course).

[devoncarew]

dart analyze is also using the analysis server's status analysis events to know when analysis starts and stops. That's not really what that event is intended to signify. We could:

• change the status.analysis event to fire isAnalyzing false until after the plugins report their results, and update the docs for the status message
• add a new event that clients could use to know when the analysis server was completely done processing a set of changes

[srawlins]

As dart analyze is the new primary supported tool, I've changed the title of this issue.

[bwilkerson]

We might want to close the issue. The dartanalyzer tool did not run plugins, but dart analyze does.

[bwilkerson]

Or, after briefly looking at the conversation, change the title to reflect the new problem: that there's no indication from server when all plugins have provided their results.