Skip ts_bindings_test and run web_generator tests with VM #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like we were silently skipping scrape_mdn_test.dart before because we never ran the tests in this package with the VM.
1 task
kevmoo
approved these changes
Jun 10, 2025
|
Thanks! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 13, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. protobuf (https://github.com/dart-lang/protobuf/compare/32d53da..0bfff0c): 0bfff0c 2025-06-10 Devon Carew update to the latest analysis lints (google/protobuf.dart#1017) tools (https://github.com/dart-lang/tools/compare/e84cbd9..72e6cc8): 72e6cc87 2025-06-11 Ben Konyi Don't emit two WatchEvents when creating a file in a non-existent directory on Windows (dart-lang/tools#2111) web (https://github.com/dart-lang/web/compare/de6b3e4..c8c1c28): c8c1c28 2025-06-10 Srujan Gaddam Skip ts_bindings_test and run web_generator tests with VM (dart-lang/web#373) Change-Id: Ibdd74ac0e40801c83eb87737095276341863a39c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434525 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we were silently skipping scrape_mdn_test.dart before because we never ran the tests in this package with the VM.