Skip to content

Set Go patch version in go.mod #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Set Go patch version in go.mod #2466

merged 1 commit into from
Mar 11, 2025

Conversation

andrewnester
Copy link
Contributor

@andrewnester andrewnester commented Mar 11, 2025

Changes

Set Go patch version in go.mod

Why

Our dependabot PRs failing with the following diff

Run # Exit with status code 1 if there are differences (i.e. unformatted files)
diff --git a/go.mod b/go.mod
index 5c1cb1d..493152a 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,[7](https://github.com/databricks/cli/actions/runs/13768953030/job/38502532441?pr=2459#step:5:8) @@
 module github.com/databricks/cli
 
-go 1.23
+go 1.23.0
+

While I'm not 100% sure why it started to happen, setting the patch version at least should fix these PR.

This might be related to this change in Go golang/go#69095 and the fact that the proposal is to enforce 1.(N-1).0 version in go.mod. 1.24 version of released in mid of February so altogether this might be a reason why it started to fail

@andrewnester andrewnester added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 676140c Mar 11, 2025
9 checks passed
@andrewnester andrewnester deleted the set-go-patch-version branch March 11, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants