Set CWD to bundle root in bundle commands #2686
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
force-pushed
the
denik/set-cwd-bundle-root
branch
from
699ea7c to
b1544fc
Compare
denik
force-pushed
the
denik/set-cwd-bundle-root
branch
from
7fe92d5 to
b8e330a
Compare
denik
force-pushed
the
denik/set-cwd-bundle-root
branch
from
de2d5df to
3180815
Compare
denik
requested review from
pietern,
andrewnester,
shreyas-goenka and
anton-107
as code owners
denik
changed the title
| } | ||
|
|
||
| abs := filepath.Join(cwd, *pathPtr) | ||
| rel, err := filepath.Rel(root, abs) |
There was a problem hiding this comment.
This will fail if we provide DATABRICKS_BUNDLE_ROOT which is outside of CWD. Can we have a test for this to confirm setting DATABRICKS_BUNDLE_ROOT works as expected?
|
JFYI See https://github.com/databricks/cli/pull/2555/files#diff-a20d49a34bb0f2a3c96a0fa01f1b990f6d15870a751ecf9eb3b95e47fb37a10bR34 as well, this has to continue to work for apps inside the bundles |
|
This is on hold, to get the following changes in first:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In bundle commands, set CWD early to bundle root.
Why
This aligns with internal representation where all files are relative to bundle root and most subprocesses should be run within bundle root directory.
Some parts of code could be simplified (e.g. path.Glob or opening files) - previously we always had to convert to abs path first, now we can process the paths directly. (I did not do all possible simplifications, just a few obvious ones that did not break any tests).
Less testing required - we don't need to test as much anymore that all features work when running bundle commands in directory different from bundle root. We only need to test boundary conditions w.r.t parameters passed.
Tests
Existing tests.