Skip to content

Fix serialization issues for generated resources #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix serialization issues for generated resources #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f387c7
Fix serialization in generated objects
hectorcast-db Oct 4, 2023
c27a0c8
Remove duplicated test
hectorcast-db Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codegen/service.py.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class {{.Name}}API:{{if .Description}}
{{- define "method-param-bind" -}}
{{- if not .Entity }}None # ERROR: No Type
{{- else if .Entity.ArrayValue }}[
{{- if .Entity.ArrayValue.IsObject -}}v.as_dict()
{{- if or .Entity.ArrayValue.IsObject .Entity.ArrayValue.IsExternal -}}v.as_dict()
{{- else if .Entity.ArrayValue.Enum -}}v.value
{{- else}}v{{end}} for v in {{.SnakeName}}]
{{- else if .Entity.IsObject }}{{.SnakeName}}.as_dict()
Expand Down
6 changes: 4 additions & 2 deletions databricks/sdk/service/jobs.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions databricks/sdk/service/sharing.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@
import pytest
import requests

from databricks.sdk import WorkspaceClient
from databricks.sdk.core import (ApiClient, Config, CredentialsProvider,
DatabricksCliTokenSource, DatabricksError,
HeaderFactory, StreamingResponse,
databricks_cli)
from databricks.sdk.service.catalog import PermissionsChange
from databricks.sdk.service.iam import AccessControlRequest
from databricks.sdk.version import __version__

from .conftest import noop_credentials
Expand Down Expand Up @@ -292,6 +295,30 @@ def test_api_client_do_custom_headers(config, requests_mock):
assert res == {"well": "done"}


def test_access_control_list(config, requests_mock):
requests_mock.post("http://localhost/api/2.1/jobs/create",
request_headers={"User-Agent": config.user_agent})

w = WorkspaceClient(config=config)
res = w.jobs.create(access_control_list=[AccessControlRequest(group_name="group")])

assert requests_mock.call_count == 1
assert requests_mock.called
assert requests_mock.last_request.json() == {'access_control_list': [{'group_name': 'group'}]}


def test_shares(config, requests_mock):
requests_mock.patch("http://localhost/api/2.1/unity-catalog/shares/jobId/permissions",
request_headers={"User-Agent": config.user_agent})

w = WorkspaceClient(config=config)
res = w.shares.update_permissions(name="jobId", changes=[PermissionsChange(principal="principal")])

assert requests_mock.call_count == 1
assert requests_mock.called
assert requests_mock.last_request.json() == {'changes': [{'principal': 'principal'}]}


def test_error(config, requests_mock):
errorJson = {
"message":
Expand Down