Add custom Duration and Timestamp classes with nanosecond support #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
reviewed
May 21, 2025
Comment on lines
+28
to
+42
| def __init__(self, seconds: int = 0, nanoseconds: int = 0) -> None: | ||
| """Initialize a Duration with seconds and nanoseconds. | ||
|
|
||
| Args: | ||
| seconds: Number of seconds | ||
| nanoseconds: Number of nanoseconds (0-999999999) | ||
|
|
||
| Raises: | ||
| TypeError: If seconds or nanoseconds are not integers | ||
| ValueError: If nanoseconds is not between 0 and 999999999 | ||
| """ | ||
| if not isinstance(seconds, int): | ||
| raise TypeError("seconds must be an integer") | ||
| if not isinstance(nanoseconds, int): | ||
| raise TypeError("nanoseconds must be an integer") |
There was a problem hiding this comment.
Why do we need this type check when we explicitly stated that in the function arguments?
There was a problem hiding this comment.
The type in the arguments are only "hints" for the linter, but python does not enforce them.
| self.nanoseconds = nanoseconds | ||
|
|
||
| @classmethod | ||
| def from_timedelta(cls, td: timedelta) -> "Duration": |
There was a problem hiding this comment.
This is returning "Duration" with quotes. Is this expected?
There was a problem hiding this comment.
Yes. In Python you cannot use a type before introduced. This is a workaround introduced at some point:
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add custom Duration and Timestamp classes with nanosecond support
How is this tested?
Added tests
NO_CHANGELOG=true