Skip to content

Commit 7275090

Browse files
Fix build scripts (#311)
* updated build scripts to use specific version of Ubuntu and update code coverage related actions * removed sudo update-alternatives
1 parent 32efa35 commit 7275090

File tree

5 files changed

+38
-5
lines changed

5 files changed

+38
-5
lines changed

.github/workflows/codeql-analysis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ on:
1818
jobs:
1919
analyze:
2020
name: Analyze
21-
runs-on: ubuntu-latest
21+
runs-on: ubuntu-22.04
2222

2323
strategy:
2424
fail-fast: false
@@ -31,9 +31,9 @@ jobs:
3131

3232
# Initializes the CodeQL tools for scanning.
3333
- name: Initialize CodeQL
34-
uses: github/codeql-action/init@v2
34+
uses: github/codeql-action/init@v3
3535
with:
3636
languages: ${{ matrix.language }}
3737

3838
- name: Perform CodeQL Analysis
39-
uses: github/codeql-action/analyze@v2
39+
uses: github/codeql-action/analyze@v3

.github/workflows/push.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
jobs:
1010
tests:
1111
# Ubuntu latest no longer installs Python 3.9 by default so install it
12-
runs-on: ubuntu-latest
12+
runs-on: ubuntu-22.04
1313
steps:
1414
- name: Checkout
1515
uses: actions/checkout@v4
@@ -26,6 +26,10 @@ jobs:
2626
# key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
2727
# restore-keys: |
2828
# ${{ runner.os }}-go-
29+
- name: Set Java 8
30+
run: |
31+
sudo update-alternatives --set java /usr/lib/jvm/temurin-8-jdk-amd64/bin/java
32+
java -version
2933
3034
- name: Set up Python 3.8
3135
uses: actions/setup-python@v5

.github/workflows/release.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77

88
jobs:
99
release:
10-
runs-on: ubuntu-latest
10+
runs-on: ubuntu-22.04
1111
environment: release
1212
permissions:
1313
# Used to authenticate to PyPI via OIDC and sign the release's artifacts with sigstore-python.
@@ -19,6 +19,11 @@ jobs:
1919
- name: Checkout
2020
uses: actions/checkout@v4
2121

22+
- name: Set Java 8
23+
run: |
24+
sudo update-alternatives --set java /usr/lib/jvm/temurin-8-jdk-amd64/bin/java
25+
java -version
26+
2227
- name: Set up Python 3.8
2328
uses: actions/setup-python@v5
2429
with:

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
## Change History
44
All notable changes to the Databricks Labs Data Generator will be documented in this file.
55

6+
### unreleased
7+
8+
#### Fixed
9+
* Updated build scripts to use Ubuntu 22.04 to correspond to environment in Databricks runtime
10+
611
### Version 0.4.0 Hotfix 2
712

813
#### Fixed

CONTRIBUTING.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,3 +158,22 @@ Basically it follows the Python PEP8 coding conventions - but method and argumen
158158
with a lower case letter rather than underscores following Pyspark coding conventions.
159159

160160
See https://legacy.python.org/dev/peps/pep-0008/
161+
162+
# Github expectations
163+
When running the unit tests on Github, the environment should use the same environment as the latest Databricks
164+
runtime latest LTS release. While compatibility is preserved on LTS releases from Databricks runtime 10.4 onwards,
165+
unit tests will be run on the environment corresponding to the latest LTS release.
166+
167+
Libraries will use the same versions as the earliest supported LTS release - currently 10.4 LTS
168+
169+
This means for the current build:
170+
171+
- Use of Ubuntu 22.04 for the test runner
172+
- Use of Java 8
173+
- Use of Python 3.11
174+
175+
See the following resources for more information
176+
= https://docs.databricks.com/en/release-notes/runtime/15.4lts.html
177+
- https://docs.databricks.com/en/release-notes/runtime/10.4lts.html
178+
- https://github.com/actions/runner-images/issues/10636
179+

0 commit comments

Comments
 (0)