-
Notifications
You must be signed in to change notification settings - Fork 74
Fix build scripts #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build scripts #311
Conversation
…de coverage related actions
.github/workflows/push.yml
Outdated
run: | | ||
sudo update-alternatives --set java /usr/lib/jvm/temurin-8-jdk-amd64/bin/java | ||
java -version | ||
sudo update-alternatives --config java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove sudo update-alternatives --config java
now that the Java version conflicts are resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will -do
.github/workflows/release.yml
Outdated
run: | | ||
sudo update-alternatives --set java /usr/lib/jvm/temurin-8-jdk-amd64/bin/java | ||
java -version | ||
sudo update-alternatives --config java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove sudo update-alternatives --config java
from the push and release scripts. java -version
should be good enough to display the current version, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes for github actions and coverage
Proposed changes
Fixed runtime to ubuntu-22.04. Updated code coverage actions
Types of changes
What types of changes does your code introduce to dbldatagen?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Changes to CICD process only - no code changes