Skip to content

Fix build scripts #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix build scripts #311

merged 2 commits into from
Feb 11, 2025

Conversation

ronanstokes-db
Copy link
Collaborator

@ronanstokes-db ronanstokes-db commented Feb 11, 2025

Fixes for github actions and coverage

Proposed changes

Fixed runtime to ubuntu-22.04. Updated code coverage actions

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

Changes to CICD process only - no code changes

@ronanstokes-db ronanstokes-db self-assigned this Feb 11, 2025
@ronanstokes-db ronanstokes-db requested review from a team as code owners February 11, 2025 22:10
@ronanstokes-db ronanstokes-db requested review from suryasaitura-db and nfx and removed request for a team February 11, 2025 22:10
run: |
sudo update-alternatives --set java /usr/lib/jvm/temurin-8-jdk-amd64/bin/java
java -version
sudo update-alternatives --config java
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove sudo update-alternatives --config java now that the Java version conflicts are resolved.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will -do

run: |
sudo update-alternatives --set java /usr/lib/jvm/temurin-8-jdk-amd64/bin/java
java -version
sudo update-alternatives --config java
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Collaborator

@ghanse ghanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove sudo update-alternatives --config java from the push and release scripts. java -version should be good enough to display the current version, right?

Copy link
Collaborator

@ghanse ghanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronanstokes-db ronanstokes-db merged commit 7275090 into master Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants