Skip to content

Fix build scripts #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
runs-on: ubuntu-22.04

strategy:
fail-fast: false
Expand All @@ -31,9 +31,9 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v3
6 changes: 5 additions & 1 deletion .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
tests:
# Ubuntu latest no longer installs Python 3.9 by default so install it
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -26,6 +26,10 @@ jobs:
# key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
# restore-keys: |
# ${{ runner.os }}-go-
- name: Set Java 8
run: |
sudo update-alternatives --set java /usr/lib/jvm/temurin-8-jdk-amd64/bin/java
java -version

- name: Set up Python 3.8
uses: actions/setup-python@v5
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
release:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
environment: release
permissions:
# Used to authenticate to PyPI via OIDC and sign the release's artifacts with sigstore-python.
Expand All @@ -19,6 +19,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- name: Set Java 8
run: |
sudo update-alternatives --set java /usr/lib/jvm/temurin-8-jdk-amd64/bin/java
java -version

- name: Set up Python 3.8
uses: actions/setup-python@v5
with:
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
## Change History
All notable changes to the Databricks Labs Data Generator will be documented in this file.

### unreleased

#### Fixed
* Updated build scripts to use Ubuntu 22.04 to correspond to environment in Databricks runtime

### Version 0.4.0 Hotfix 2

#### Fixed
Expand Down
19 changes: 19 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,3 +158,22 @@ Basically it follows the Python PEP8 coding conventions - but method and argumen
with a lower case letter rather than underscores following Pyspark coding conventions.

See https://legacy.python.org/dev/peps/pep-0008/

# Github expectations
When running the unit tests on Github, the environment should use the same environment as the latest Databricks
runtime latest LTS release. While compatibility is preserved on LTS releases from Databricks runtime 10.4 onwards,
unit tests will be run on the environment corresponding to the latest LTS release.

Libraries will use the same versions as the earliest supported LTS release - currently 10.4 LTS

This means for the current build:

- Use of Ubuntu 22.04 for the test runner
- Use of Java 8
- Use of Python 3.11

See the following resources for more information
= https://docs.databricks.com/en/release-notes/runtime/15.4lts.html
- https://docs.databricks.com/en/release-notes/runtime/10.4lts.html
- https://github.com/actions/runner-images/issues/10636