Skip to content

modified files to build for Databricks runtime 11.3 LTS compliant versions #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

ronanstokes-db
Copy link
Collaborator

Proposed changes

Modified build files and environment to be based on Databricks runtime 11.3 LTS.

This causes builds to use Python 3.9.21, Pyspark 3.3.0 and uses the same libraries as 11.3 LTS

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

For Dbldatagen, we target the oldest supported LTS version of the Databricks runtime. In rare cases, there may be exceptions, but in general the goal is to support all supported LTS versions of the Databricks runtime

@ronanstokes-db ronanstokes-db requested review from a team as code owners March 6, 2025 02:25
@ronanstokes-db ronanstokes-db requested review from suryasaitura-db and nfx and removed request for a team March 6, 2025 02:25
@ronanstokes-db ronanstokes-db self-assigned this Mar 6, 2025
@ronanstokes-db ronanstokes-db requested review from ghanse and removed request for suryasaitura-db and nfx March 6, 2025 02:25
@ronanstokes-db ronanstokes-db added this to the 0.4.1 milestone Mar 6, 2025
Copy link
Collaborator

@ghanse ghanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronanstokes-db ronanstokes-db merged commit 41fc07f into master Mar 6, 2025
1 check passed
@ronanstokes-db ronanstokes-db deleted the feature_11_3_LTS branch March 7, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants