Skip to content

add skip-auth-screen & landscape-terrain-enabled options for preview #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions packages/@dcl/sdk-commands/src/commands/start/explorer-alpha.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,24 @@ async function runApp(
const localScene = args['--local-scene'] ?? true
const debug = args['--debug'] ?? true
const dclenv = args['--dclenv'] ?? 'org'
const skipAuthScreen = args['--skip-auth-screen'] ?? true
const landscapeTerrainEnabled = args['--landscape-terrain-enabled'] ?? true

try {
const params = `realm=${realm}&position=${position}&local-scene=${localScene}&debug=${debug}&hub=${isHub}&dclenv=${dclenv}`
const app = `decentraland://"${params}"`
const queryParams = [
`realm=${realm}`,
`position=${position}`,
`local-scene=${localScene}`,
`debug=${debug}`,
`hub=${isHub}`,
`dclenv=${dclenv}`,
`skip-auth-screen=${skipAuthScreen}`,
`landscape-terrain-enabled=${landscapeTerrainEnabled}`
].join('&')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧡


const app = `decentraland://"${queryParams}"`
await components.spawner.exec(cwd, cmd, [app], { silent: true })
components.logger.info(`Desktop client: decentraland://${params}\n`)
components.logger.info(`Desktop client: decentraland://${queryParams}\n`)
return true
} catch (e: any) {
components.logger.error('Decentraland Desktop Client failed with: ', e.message)
Expand Down
32 changes: 18 additions & 14 deletions packages/@dcl/sdk-commands/src/commands/start/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ export const args = declareArgs({
'--dclenv': String,
'--realm': String,
'--local-scene': String,
'--position': String
'--position': String,
'--skip-auth-screen': Boolean,
'--landscape-terrain-enabled': Boolean
})

export async function help(options: Options) {
Expand All @@ -66,19 +68,21 @@ export async function help(options: Options) {

Options:

-h, --help Displays complete help
-p, --port [port] Select a custom port for the development server
-d, --no-debug Disable debugging panel
-b, --no-browser Do not open a new browser window
-w, --no-watch Do not open watch for filesystem changes
-c, --ci Run the parcel previewer on a remote unix server
--web3 Connects preview to browser wallet to use the associated avatar and account
--skip-build Skip build and only serve the files in preview mode
--debug Enables Debug panel mode inside DCL Explorer (default=true)
--dclenv Decentraland Environment. Which environment to use for the content. This determines the catalyst server used, asset-bundles, etc. Possible values: org, zone, today. (default=org)
--realm Realm used to serve the content. (default=Localhost)
--local-scene Enable local scene development.
--position Initial Position to start the explorer. (default=position defined at scene.json)
-h, --help Displays complete help
-p, --port [port] Select a custom port for the development server
-d, --no-debug Disable debugging panel
-b, --no-browser Do not open a new browser window
-w, --no-watch Do not open watch for filesystem changes
-c, --ci Run the parcel previewer on a remote unix server
--web3 Connects preview to browser wallet to use the associated avatar and account
--skip-build Skip build and only serve the files in preview mode
--debug Enables Debug panel mode inside DCL Explorer (default=true)
--dclenv Decentraland Environment. Which environment to use for the content. This determines the catalyst server used, asset-bundles, etc. Possible values: org, zone, today. (default=org)
--realm Realm used to serve the content. (default=Localhost)
--local-scene Enable local scene development.
--position Initial Position to start the explorer. (default=position defined at scene.json)
--skip-auth-screen Skip the auth screen.
--landscape-terrain-enabled Enable landscape terrain.


Examples:
Expand Down
Loading