Skip to content

feat: add camera movement shortcut for trackpad users #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

feat: add camera movement shortcut for trackpad users #1138

merged 1 commit into from
Jun 24, 2025

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza force-pushed the feat/trackpad-shortcut branch from 47a3f8d to d6c7568 Compare June 23, 2025 17:46
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jun 23, 2025 •
edited
Loading

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8df9921
Status: ✅  Deploy successful!
Preview URL: https://d6901178.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-trackpad-shortcut.js-sdk-toolchain.pages.dev

View logs

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025 •
edited
Loading

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/trackpad-shortcut/dcl-sdk-7.8.13-15853704856.commit-1c8ab37.tgz"

  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/trackpad-shortcut/dcl-sdk-commands-7.8.13-15853704856.commit-1c8ab37.tgz"
npx $SDK_COMMANDS init

  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/trackpad-shortcut/@dcl/inspector/dcl-inspector-7.8.13-15853704856.commit-1c8ab37.tgz"

  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/trackpad-shortcut-e2e

  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/trackpad-shortcut

gonpombo8
gonpombo8 reviewed Jun 23, 2025
View reviewed changes
@nicoecheza nicoecheza force-pushed the feat/trackpad-shortcut branch from d6c7568 to 052c45e Compare June 23, 2025 18:04
@nicoecheza nicoecheza force-pushed the feat/trackpad-shortcut branch from 052c45e to 8df9921 Compare June 24, 2025 14:45
@nicoecheza nicoecheza enabled auto-merge (squash) June 24, 2025 14:45
@Ludmilafantaniella Ludmilafantaniella self-requested a review June 24, 2025 14:45
Ludmilafantaniella
Ludmilafantaniella approved these changes Jun 24, 2025
View reviewed changes
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested on both Mac and Windows.
The new trackpad shortcut for rotating the camera (holding Alt/Option + drag) works as expected.
Also confirmed that the shortcuts list in the Inspector was updated correctly.

CH-1138

1138-CH.mp4

@nicoecheza nicoecheza merged commit db94403 into main Jun 24, 2025
9 checks passed
@nicoecheza nicoecheza deleted the feat/trackpad-shortcut branch June 24, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonpombo8 gonpombo8 gonpombo8 approved these changes

@Ludmilafantaniella Ludmilafantaniella Ludmilafantaniella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcut for rotating camera for trackpad users
3 participants
@nicoecheza @gonpombo8 @Ludmilafantaniella