Skip to content

fix required params #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

fix required params #1140

merged 2 commits into from
Jun 25, 2025

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented Jun 25, 2025

Fix boolean parameter handling in explorer-alpha command

Problem

When running the dcl start command with boolean flags like --landscape-terrain-enabled without providing a value, the command would fail. This happened because the code was treating these parameters as strings and trying to convert them to booleans, but when no value was provided, the conversion would fail.

And the creator-hub sometimes use that flag without a value so some users where having issues to preview their scenes.

Example of the failing command:

npm start -- --explorer-alpha --landscape-terrain-enabled

Copy link
Contributor

github-actions bot commented Jun 25, 2025

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/required-params/dcl-sdk-7.8.14-15878767047.commit-08340fb.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/required-params/dcl-sdk-commands-7.8.14-15878767047.commit-08340fb.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/required-params/@dcl/inspector/dcl-inspector-7.8.14-15878767047.commit-08340fb.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/required-params-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/required-params

Copy link

cloudflare-workers-and-pages bot commented Jun 25, 2025

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: d047127
Status: ✅  Deploy successful!
Preview URL: https://21075b89.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-required-params.js-sdk-toolchain.pages.dev

View logs

@gonpombo8 gonpombo8 marked this pull request as ready for review June 25, 2025 14:04
@gonpombo8 gonpombo8 merged commit 3605540 into main Jun 25, 2025
9 checks passed
@gonpombo8 gonpombo8 deleted the fix/required-params branch June 25, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants