Skip to content

Add performace test of sphbes functions. #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

grysgreat
Copy link

Using google benchmark as the background, a series of performance test code was added(https://github.com/google/benchmark.git)

Linked Issue

Fix #3491

What's changed?

  • Added compilation options for performance test code
  • Performance test code for the sphbes function has been added to module base

Any changes of core modules? (ignore if not applicable)

  • none

@jieli-matrix jieli-matrix requested a review from caic99 January 16, 2024 03:39
@jieli-matrix jieli-matrix self-assigned this Jan 16, 2024
@jieli-matrix jieli-matrix requested a review from jinzx10 January 16, 2024 03:41
@@ -608,6 +610,69 @@ IF (BUILD_TESTING)
endfunction(AddTest)
endif()


# Add performance test in abacus
IF (ENABLE_GOOGLEBENCH)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since googlebench relies on testing mechanism and googletest toolkit, please set ENABLE_GOOGLEBENCH as affiliated to BUILD_TESTING.

@jieli-matrix
Copy link
Collaborator

Since we have added performance tests where the results will show the time costs of functions by running random times, maybe we can remove timer.h from module base. cc: @mohanchen

@jieli-matrix
Copy link
Collaborator

Closed this PR since I will take on the work in PR #3511. cc: @grysgreat @caic99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added mathematical function performance tests in abacus.
3 participants