Skip to content

Fix: wrong band output when kpar > 1 #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Conversation

Qianruipku
Copy link
Collaborator

@Qianruipku Qianruipku commented Jan 11, 2025

Fix #5051
By the way, the PR also fixes the bug of wrong value of iktot. It occurs when nspin = 2. It affects read/write_wfc_pw.
Results of 101_PW_upf201_uspp_Fe are updated due to changed value of iktot.
Add tests for init_wfc && nspin = 2.

@Qianruipku Qianruipku force-pushed the hotfix branch 3 times, most recently from 557a415 to 89ce6d1 Compare January 12, 2025 12:01
@Qianruipku Qianruipku force-pushed the hotfix branch 2 times, most recently from c3350da to e591a7d Compare January 13, 2025 07:14
@Qianruipku Qianruipku closed this Jan 13, 2025
@Qianruipku Qianruipku reopened this Jan 13, 2025
@mohanchen mohanchen added The Absolute Zero Reduce the "entropy" of the code to 0 Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes labels Jan 13, 2025
@mohanchen mohanchen merged commit aced178 into deepmodeling:develop Jan 13, 2025
14 checks passed
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
* fix wrong band results when kpar>1

* fix compile

* fix: bug for init_wfc file when nspin = 2

* add new integral test

* format read_wfc_to_rho_test

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using kpar, the band information of partial k points are outputted in running_xxx.log
2 participants