forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 141
Feature: Support outputting partial charge and wave functions under PW basis when kpar > 1
#6242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mohanchen
merged 20 commits into
deepmodeling:develop
from
AsTonyshment:fix_getwf_sepk_doc
May 31, 2025
Merged
Feature: Support outputting partial charge and wave functions under PW basis when kpar > 1
#6242
mohanchen
merged 20 commits into
deepmodeling:develop
from
AsTonyshment:fix_getwf_sepk_doc
May 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…across diff pools
mohanchen
approved these changes
May 31, 2025
kluophysics
pushed a commit
to kluophysics/abacus-develop
that referenced
this pull request
Jun 5, 2025
…W basis when `kpar > 1` (deepmodeling#6242) * Fix if_separate_k description in the doc * Use nkstot instead of nks when kpar > 1 * Fix doc: set_wf -> get_wf * Fix kpar nks -> nkstot * Fix write_cube and pgrid reduce logic * Delete cout and nks -> nkstot for out_wfc_re_im * Add parameter reduce_all_pool to control reduce behavior * Delete useless parameters in get_pchg_pw * Fix incorrect pchg when if_separate_k is false due to lack of reduce across diff pools * Add integrate test 113_PW_get_pchg_kpar * Add integrate test 114_PW_get_pchg_sepk * Add integrate test 115_PW_get_wf_kpar * Add MPI compilation macros * Update 115_PW_get_wf_kpar to avoid random behavior in CI/CD test * Change param of test 115_PW_get_wf_kpar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Features Needed
The features are indeed needed, and developers should have sophisticated knowledge
Refactor
Refactor ABACUS codes
The Absolute Zero
Reduce the "entropy" of the code to 0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fix #6227
What's changed?
Parallel_Grid::reduce
, so that the operation could be done under each pool instead of pool No. zero.kpar > 1
.