feat: ChatMessage.to_openai_dict_format - add require_tool_call_ids parameter
#9481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
requested review from
dfokina and
Amnah199
and removed request for
a team
anakin87
requested review from
vblagoje and
sjrl
and removed request for
Amnah199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
to_dictinstead ofto_openai_dict_formatas it causes failure with non-OpenAI models in Langfuse haystack-core-integrations#1780Proposed Changes:
require_tool_call_idsparameter toChatMessage.to_openai_dict_formatTrue(default), if theidfield is missing in a Tool Call, an error is raised.Falseis useful for shallow OpenAI-compatible APIs, where theidfield is notrequired.
How did you test it?
CI; new tests
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.