Open
Description
What
The part of code that checks overrides for determinations, seem to always look into the id
-- while (the features bucket_type
is guid
) one would the keys on overrides
to represent guid
s.
Solution
There is an easy solution of deciding to use id
or guid
here -- however backwards compatibility is a big issue here. Two ways I can imagine we get around this:
- Do a major release and warn about the breaking change.
- Check for both
id
andguid
-- bit hacky but in reality these two never clash, so... we should be fine?
Thoughts?
/cc @jphastings
Metadata
Metadata
Assignees
Labels
No labels