fix(ext/node): add basic support of suite/describe in node:test #28847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Apr 11, 2025
| it.only = function only(name, options, fn) { | ||
| return test.only(name, options, fn); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Can you add these lines?
test.test = test;
test.describe = describe;
test.it = it;
This will make this module more in-line with Node's implementation
bartlomieju
reviewed
Apr 11, 2025
| }); | ||
|
|
||
| describe("sub describe 2", () => { | ||
| it("nested test 1", () => {}); |
There was a problem hiding this comment.
Would be nice to have failing test cases here to ensure errors are properly caught and reported
nathanwhit
pushed a commit
that referenced
this pull request
Apr 14, 2025
nathanwhit
pushed a commit
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support of suite/describe in
node:testcloses #27406
towards #28837