BREAKING(tar/unstable): fix handling of mode, uid, and gid

[BlackAsLight]

Closes: #6376

This pull request makes the changes discussed in the other linked pull request.

It changes mode, uid, and gid to accept and decode numbers in the octal format 0o775 instead of decimal format 775. It also changes slightly the decoding segment of these three to be more compatible with other tar specs.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (71c828a) to head (101ba12).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6440      +/-   ##
==========================================
- Coverage   95.98%   95.98%   -0.01%     
==========================================
  Files         564      564              
  Lines       42482    42476       -6     
  Branches     6394     6391       -3     
==========================================
- Hits        40775    40769       -6     
  Misses       1668     1668              
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kt3k]

I missed this in #6376, but I don't think UID and GID are generally handled as octals. See docs of Deno.chown for example. https://docs.deno.com/api/deno/~/Deno.chown

Can we do these changes only for 'mode'?

[BlackAsLight]

We can but the spec is only expecting octal digits to be written

[0f-0b]

I agree that this change should be done for UID and GID as well. Currently, to set the UID to, for example, 501, the user would have to write uid: 765 (the octal representation of 501 disguised as a decimal literal), which doesn't make sense to me.

import { TarStream, type TarStreamInput } from "jsr:@std/[email protected]/tar-stream";

const file = new Blob(["hello world\n"]);
await ReadableStream.from<TarStreamInput>([
  {
    type: "file",
    path: "hello.txt",
    size: file.size,
    readable: file.stream(),
    options: { uid: 765, gid: 24, mtime: 0 },
  },
])
  .pipeThrough(new TarStream())
  .pipeTo(Deno.stdout.writable);

$ deno run a.ts | tar tv
-rw-r--r--  0 501    20         12 Jan  1  1970 hello.txt

[kt3k]

@0f-0b Ah, ok. That sounds correct. This part needs to be encoded in octals. Thanks for pointing this!

[kt3k]

LGTM. Thanks for the fix!