Skip to content

feat(fs/unstable): add utime and utimeSync #6446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 28, 2025
Merged

Conversation

WasixXD
Copy link
Contributor

@WasixXD WasixXD commented Feb 26, 2025

This PR is part of the #6255 and adds the utime and utimeSync to the API

@WasixXD WasixXD requested a review from kt3k as a code owner February 26, 2025 13:59
@github-actions github-actions bot added the fs label Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 15 lines in your changes missing coverage. Please review.

Project coverage is 95.97%. Comparing base (ae95786) to head (c59c908).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_utime.ts 58.33% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6446      +/-   ##
==========================================
- Coverage   96.01%   95.97%   -0.05%     
==========================================
  Files         566      567       +1     
  Lines       42535    42565      +30     
  Branches     6392     6396       +4     
==========================================
+ Hits        40841    40850       +9     
- Misses       1661     1682      +21     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Feb 27, 2025

Almost looks good to me. Can you add fs/unstable_utime.ts entry to _tools/check_docs.ts?

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 3ae564b into denoland:main Feb 28, 2025
18 checks passed
eryue0220 added a commit to eryue0220/deno_std that referenced this pull request Mar 2, 2025
…no_std into feat/fs-unstable-remove-api

* 'feat/fs-unstable-remove-api' of github.com:eryue0220/deno_std:
  feat(fs/unstable): add umask (denoland#6454)
  feat(fs/unstable): add utime and utimeSync (denoland#6446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants