Skip to content

BREAKING(encoding/unstable): merge Base32Hex(Encoder|Decoder)Stream to Base32(Encoder|Decoder)Stream #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Mar 13, 2025
Merged

BREAKING(encoding/unstable): merge Base32Hex(Encoder|Decoder)Stream to Base32(Encoder|Decoder)Stream #6452

merged 33 commits into from
Mar 13, 2025

Conversation

BlackAsLight
Copy link
Contributor

Jumping from: #6442

Pulling the unstable base32 content out into a separate pull request

@BlackAsLight
perf(encoding): base64
d4ba5bf
@BlackAsLight
perf(encoding): base64url
c1eccd4
@BlackAsLight
perf(encoding): base32
df36993
@BlackAsLight
perf(encoding): base32hex
ea879eb
@BlackAsLight
chore(encoding): add missing copyright comment
2103c65
@BlackAsLight
adjust(encoding): base64 to use switch instead of if
ba88700
@BlackAsLight
chore(encoding): update exports
8f671ae
@BlackAsLight
chore(encoding): fmt
56b6f99
@BlackAsLight
perf(encoding): hex
71e0246
@BlackAsLight
chore(encoding): remove file committed on accident
a0ac03e
@BlackAsLight
perf(encoding): update streams to be more memory efficient
927c2e7
@BlackAsLight
perf(encoding): base32crockford
39a3026
@BlackAsLight
Merge branch 'denoland:main' into encoding_refactor
6bb70e5
@BlackAsLight
chore(encoding): fix docs
994124b
@BlackAsLight
revert(encoding): perf brought to stable exports
01477c2
@BlackAsLight
docs(encoding): fix mismatch type
5acf1fc
@BlackAsLight
chore(encoding): add missing export
6112d8a
@BlackAsLight
chore(encoding): remove file committed on accident
4bb9d91
@BlackAsLight
perf(encoding): base32crockford stream
3b91390
@BlackAsLight
fix(encoding): types for deno v1.x
75778c2
@BlackAsLight
fix(encoding): types for deno v1.x
d4fcd64
@BlackAsLight
refactor(encoding): to bring perf to stable packages
ec1d78e 
- Bring performance to stable packages
- Change how the Raw encoders and decoders work to encode inline in an existing buffer
@BlackAsLight
refactor(encoding): merging same base functions & adding tests & docs
78e3c9d 
- Merged Base32, Base32Hex, and Base32Crockford into one file.
- Merged Base64, and Base64Url into one file.
- Added Tests for 100% coverage.
- Added JSDocs
@BlackAsLight
chore(tools): update check_docs.ts entrypoint
0bec310
@BlackAsLight
chore(encoding): fix types of deno v1.x
8edd5e2
@BlackAsLight
Merge branch 'main' into encoding_refactor
8cffee7
@BlackAsLight
revert(encoding): all changes except unstable base32
94eef75
@BlackAsLight BlackAsLight requested a review from kt3k as a code owner February 27, 2025 08:10
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.35294% with 12 lines in your changes missing coverage. Please review.

Project coverage is 95.69%. Comparing base (347926a) to head (f216a5c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
encoding/unstable_base32_stream.ts 82.35% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6452      +/-   ##
==========================================
- Coverage   95.71%   95.69%   -0.03%     
==========================================
  Files         575      574       -1     
  Lines       43192    43182      -10     
  Branches     6475     6469       -6     
==========================================
- Hits        41342    41322      -20     
- Misses       1816     1825       +9     
- Partials       34       35       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BlackAsLight BlackAsLight changed the title BREAKING(encoding) add code consistency and performance for unstable base32 BREAKING(encoding) add code consistency and performance for unstable base32. Feb 27, 2025
@BlackAsLight BlackAsLight changed the title BREAKING(encoding) add code consistency and performance for unstable base32. BREAKING(encoding) add code consistency and performance for unstable base32 Feb 27, 2025
@BlackAsLight BlackAsLight changed the title BREAKING(encoding) add code consistency and performance for unstable base32 BREAKING(encoding): add code consistency and performance for unstable base32 Feb 27, 2025
@BlackAsLight BlackAsLight marked this pull request as draft March 3, 2025 01:31
@BlackAsLight BlackAsLight mentioned this pull request Mar 9, 2025
Merged
@BlackAsLight BlackAsLight marked this pull request as ready for review March 13, 2025 06:30
@BlackAsLight BlackAsLight changed the title BREAKING(encoding): add code consistency and performance for unstable base32 BREAKING(encoding/unstable): merge Base32Hex(Encoder|Decoder)Stream to Base32(Encoder|Decoder)Stream Mar 13, 2025
kt3k
kt3k approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit bcb30bb into denoland:main Mar 13, 2025
18 checks passed
@BlackAsLight BlackAsLight deleted the encoding_base32_refactor branch March 13, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
encoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlackAsLight @kt3k