Skip to content

BREAKING(cli/unstable): remove trailing whitespaces from ProgressBarFormatter properties #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

BREAKING(cli/unstable): remove trailing whitespaces from ProgressBarFormatter properties #6502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21ef813
initial commit
timreichen Mar 21, 2025
553bc87
Merge branch 'main' into cli-ProgressBar-remove-trailing-whitespaces-…
timreichen Mar 24, 2025
0e03c84
Merge branch 'main' into cli-ProgressBar-remove-trailing-whitespaces-…
timreichen Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cli/unstable_progress_bar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,18 @@
export interface ProgressBarFormatter {
/**
* A function that returns a formatted version of the duration.
* `[mm:ss] `
* `[mm:ss]`
*/
styledTime: () => string;
/**
* A function that returns a formatted version of the data received.
* `[0.40/97.66 KiB] `
* `[0.40/97.66 KiB]`
* @param fractions The number of decimal places the values should have.
*/
styledData: (fractions?: number) => string;
/**
* The progress bar string.
* Default Style: `[###-------] `
* Default Style: `[###-------]`
*/
progressBar: string;
/**
Expand Down Expand Up @@ -172,7 +172,7 @@ export class ProgressBar {
fillChar = "#",
emptyChar = "-",
clear = false,
fmt = (x) => x.styledTime() + x.progressBar + x.styledData(),
fmt = (x) => `${x.styledTime()} ${x.progressBar} ${x.styledData()} `,
keepOpen = true,
} = options;
this.#value = value;
Expand Down Expand Up @@ -223,14 +223,14 @@ export class ProgressBar {
styledTime() {
const minutes = (this.time / 1000 / 60 | 0).toString().padStart(2, "0");
const seconds = (this.time / 1000 % 60 | 0).toString().padStart(2, "0");
return `[${minutes}:${seconds}] `;
return `[${minutes}:${seconds}]`;
},
styledData: (fractions = 2): string => {
const currentValue = (this.#value / this.#rate).toFixed(fractions);
const maxValue = (this.#max / this.#rate).toFixed(fractions);
return `[${currentValue}/${maxValue} ${this.#unit}] `;
return `[${currentValue}/${maxValue} ${this.#unit}]`;
},
progressBar: `[${fillChars}${emptyChars}] `,
progressBar: `[${fillChars}${emptyChars}]`,
time: currentTime - this.#startTime,
previousTime: this.#lastTime - this.#startTime,
value: this.#value,
Expand Down
Loading