Skip to content

refactor(ini): simplify parse() #6512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 7, 2025
Merged

Conversation

timreichen
Copy link
Contributor

This PR moves all parser functionality from IniMap into the parse() function.
There is a load of unnecessary overhead generated the way parse() works in IniMap.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (f5795f8) to head (a163e78).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6512      +/-   ##
==========================================
+ Coverage   95.08%   95.32%   +0.24%     
==========================================
  Files         576      575       -1     
  Lines       43337    43160     -177     
  Branches     6464     6463       -1     
==========================================
- Hits        41207    41144      -63     
+ Misses       2089     1976     -113     
+ Partials       41       40       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timreichen timreichen requested a review from kt3k April 1, 2025 07:02
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit f80315f into denoland:main Apr 7, 2025
18 checks passed
@timreichen timreichen deleted the ini-simplify-parse branch April 7, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants