Skip to content

refactor(toml): add Scanner startsWith() method #6532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

timreichen
Copy link
Contributor

This reduces the usage of slice() and might have a positive impact on performance.

@timreichen timreichen requested a review from kt3k as a code owner March 30, 2025 10:38
@github-actions github-actions bot added the toml label Mar 30, 2025
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (68a8460) to head (3e96168).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6532      +/-   ##
==========================================
- Coverage   95.08%   95.08%   -0.01%     
==========================================
  Files         576      576              
  Lines       43337    43339       +2     
  Branches     6466     6466              
==========================================
+ Hits        41208    41209       +1     
- Misses       2089     2090       +1     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timreichen timreichen changed the title feat(toml): add Scanner startsWith method feat(toml): add Scanner startsWith() method Mar 30, 2025
@kt3k kt3k changed the title feat(toml): add Scanner startsWith() method refactor(toml): add Scanner startsWith() method Apr 7, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. LGTM

@kt3k kt3k merged commit fcc1491 into denoland:main Apr 7, 2025
19 checks passed
@timreichen timreichen deleted the toml-add-Scanner-startsWith-method branch April 7, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants