refactor(yaml): add skipComment() method
#6588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6588 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 579 579
Lines 43752 43752
Branches 6494 6487 -7
=======================================
+ Hits 41381 41382 +1
+ Misses 2331 2330 -1
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kt3k
reviewed
Apr 18, 2025
| do { | ||
| ch = this.next(); | ||
| } while (ch !== 0 && !isEOL(ch)); | ||
| break; |
There was a problem hiding this comment.
We now miss this break path. Is this change intentional?
There was a problem hiding this comment.
This is intentional. A yaml comment ends only on eol or eof. The yaml string will be invalid on eof at that stage and eol is handled by the next line if (isEOL(ch)) break;.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.