Skip to content

fix(dotenv): prevent prototype pollution during parsing #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

lucacasonato
Copy link
Member

If you did

toString=FOO

that would overwrite Object.prototype.toString.

@lucacasonato lucacasonato requested a review from kt3k as a code owner May 20, 2025 14:17
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.69%. Comparing base (ba0fc29) to head (f90a810).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6661      +/-   ##
==========================================
- Coverage   94.70%   94.69%   -0.01%     
==========================================
  Files         562      562              
  Lines       46646    46651       +5     
  Branches     6569     6570       +1     
==========================================
+ Hits        44174    44178       +4     
- Misses       2429     2430       +1     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k merged commit 001a602 into main May 23, 2025
19 checks passed
@kt3k kt3k deleted the use_null_prototype_dotenv branch May 23, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants