Skip to content

fix(text/unstable): make dedent match reference for multiline substitutions #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

WWRS
Copy link
Contributor

@WWRS WWRS commented May 21, 2025

fixes #6665

@WWRS WWRS requested a review from kt3k as a code owner May 21, 2025 15:24
@github-actions github-actions bot added the text label May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.69%. Comparing base (2e6ac51) to head (ba644a6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6667      +/-   ##
==========================================
- Coverage   94.69%   94.69%   -0.01%     
==========================================
  Files         562      562              
  Lines       46648    46651       +3     
  Branches     6569     6570       +1     
==========================================
+ Hits        44175    44177       +2     
- Misses       2430     2431       +1     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k changed the title fix(text): make dedent match reference for multiline substitutions fix(text/unstable): make dedent match reference for multiline substitutions May 23, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k kt3k merged commit a027a36 into denoland:main May 23, 2025
20 checks passed
@WWRS WWRS deleted the dedent-multisub branch May 23, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text/unstable-dedent gives poor results when interpolating multi-line text into tagged template
2 participants