Skip to content

chore: revert "refactor(cli/unstable): string based ProgressBar tests (#6679)" #6684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 27, 2025

This reverts commit e10c71a which introduced some flakiness in CI

@github-actions github-actions bot added the cli label May 27, 2025
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (e10c71a) to head (08cfbeb).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6684   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         567      567           
  Lines       46778    46778           
  Branches     6582     6582           
=======================================
+ Hits        44305    44306    +1     
+ Misses       2431     2430    -1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member Author

kt3k commented Jun 6, 2025

This is no longer necessary as we chose to use FakeTime for reducing flakiness. #6686

@kt3k kt3k closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants