to-directory-tree: Create parents of files when using fixpoint directory tree representation
#2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, when one uses `to-directory-tree --allow-path-separators` to create a file using the fixpoint representation of a filesystem tree, then that failed if a path with path separators was passed to the `file` or `binary-file` constructors. The reason was that we did not create the parent directories, which is intended by the use of --allow-path-separators. This commit fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one uses
dhall to-directory-tree --allow-path-separatorsto create a file using the fixpoint representation of a filesystem tree, then that failed if a path with path separators was passed to thefileorbinary-fileconstructors and the parent directory of the file in question did not exist.This PR fixes that by ensuring that the parent directory does exist.