Docs, spelling and testing #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhylands
reviewed
Feb 11, 2017
lcd/pyb_i2c_lcd_test.py
Outdated
| @@ -1,7 +1,7 @@ | |||
| """Implements a HD44780 character LCD connected via PCF8574 on I2C.""" | |||
|
|
|||
| from pyb import I2C, delay, millis | |||
| from lcd_api import LcdApi | |||
| from pyb_i2c_lcd import I2cLcd | |||
There was a problem hiding this comment.
For some reason, I wasn't seeing all of the commits, so my comments might not be relevant. Let me review everything as a whole.
lcd/pyb_i2c_lcd_test.py
Outdated
| @@ -1,7 +1,7 @@ | |||
| """Implements a HD44780 character LCD connected via PCF8574 on I2C.""" | |||
|
|
|||
| from pyb import I2C, delay, millis | |||
| from lcd_api import LcdApi | |||
There was a problem hiding this comment.
I had to add that line on my OpenMV board or I ran into recursion depth issues.
pyb_i2c_lcd_test was importing pyb_i2c_lcd, which was importing lcd_api. On my pyboard this works fine, but on my OpenMV board, it would fail. By adding an import of LcdApi at this level, the import of LcdApi in pyb_i2c_lcd would just import the already imported module.
There was a problem hiding this comment.
ok - this comment is still valid. but I see the next one is correcting an earlier deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also moved tests out of
i2c_lcd.pybinto a new filei2c_lcd_test.pyb, to match other examples.