Skip to content

Official Gradle Wrapper Validation GitHub Action #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

JLLeitschuh
Copy link
Member

@JLLeitschuh
Copy link
Member Author

@nedtwigg
Copy link
Member

Huzzah! Two questions:

  1. should we now revert Replace check gradle checksums with fetched script #488?
  2. I don't have any experience with GitHub Actions, but looks like you do. Any advantages in porting this over to consolidate?

@JLLeitschuh
Copy link
Member Author

The reason that Paul and I chose to use GitHub actions are that they are as simple as merging a file to enable them. You don't need to do anything else.

With this check, #488 should no longer be necessary.

As for porting from Travis, that's a personal opinion. I've keep many of my projects running on Travis simply because I don't have the cycles to make the change, nor do I really care as long as I get the CI check and the auto-publish that I use.

@nedtwigg
Copy link
Member

Sounds good! How about you revert the #488 merge commit, and then press the "merge" button. Thanks for to you and @ZacSweers for keeping us safe :)

@JLLeitschuh
Copy link
Member Author

JLLeitschuh commented Jan 15, 2020

I actually opened this PR completely through the GitHub web UI and looks like I don't even have a local copy of spotless on my machine.

Upon further reflection, there's no reason not to keep @ZacSweers's check, while redundant, it is an effective gate from building a release without the prerequisite of the wrapper being valid having been satisfied.

I could go either way on keeping it or not.

@nedtwigg nedtwigg merged commit 611d195 into master Jan 15, 2020
@ZacSweers
Copy link
Contributor

Very cool!

@nedtwigg nedtwigg deleted the JLLeitschuh-patch-1 branch May 3, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants