FIX: Add new attribute that is required when using the basic topic serializer #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaffeux
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discourse/discourse#32618 we added the dependency on locales to the basic topic serializer gated behind
SiteSetting.experimental_content_localization. This is so that fancy_titles can be rendered in the language of the user.Error:
This PR adds that dependency to
extra_data_pluck_fieldswhich lists fields required from the serializer.Reviewer note: The test will pass despite not adding locale, as the experimental setting is false by default. Once this experimental setting is removed, the test will be effective to check that the BasicTopicSerializer serializes without errors. Also, I had considered making the check in core less reliant on the locale attribute, but I believe we should not need to update core for a plugin.