Add option to allow chroot specs for COPR builds (b0.69) #2621
Conversation
Add a CHROOTS variable to the agent/rpm/Makefile and an option to the `copr-cli build' command in rpm.mk, to allow the specification of chroots to include or exclude in a build. The default setting for the b0.69 branch excludes all RHEL9 builds: the 0.69 agent does not work on RHEL9 because of an `scp -r' bug.
ndokos
changed the title
There was a problem hiding this comment.
Looks OK to me (although, I would have preferred that we use $CHROOTS to specify the platforms that we do support rather than to list the ones which we don't support (at this moment), but I guess that this will work).
However, there is a failing test, which looks like it might be due to a non-deterministic output ordering? (Either that, or someone slipped in a prior change without a gold file update....) I'm not sure what we should be doing about this....
There was a problem hiding this comment.
Given it's a "Make-do" (pardon the pun) for 0.69, this is OK. I think the label CHROOTS is a bit misleading for a value that needs to contain the copr-cli options to select/exclude chroots (and in fact can contain any copr-cli options)... it's not perfect, (or elegant), but it's probably good enough for now. 👍🏻
Add a CHROOTS variable to the agent/rpm/Makefile and an option
to the `copr-cli build' command in rpm.mk, to allow
the specification of chroots to include or exclude in a build.
The default setting for the b0.69 branch excludes all RHEL9 builds:
the 0.69 agent does not work on RHEL9 because of an `scp -r' bug.