Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of a bunch of tiny fixes of minimal consequence which I've gradually accumulated over the last month. They were things which I ran into in the course of making other changes, but, since they had nothing to do with the changes I was making, I kept them on a side branch. At this point, there are enough of them to warrant putting up a review.
load_keycloak.sh
urllib3
package and add a requirement for it: the package is apparently included inside therequests
package, and we were referencing it there instead of declaring our own dependency on it.deploy-dependencies
script: this script is normally invoked by a higher-level script which provides these definitions; if a user wants to run this script independently, then s/he has to "just know" to provide these definitions in the environment; this change provides reasonable default values if the variables are not already defined.exec
call inside the script which is run as the container entrypoint will fail, and this results in a cryptic response (if any) for the user. This PR modifies the entry point script script to try to handle these cases better for the user.