Skip to content

Remove rem units from svg #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Remove rem units from svg #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6ceaa4
Use css properties for height and width
michjnich Jul 4, 2024
9cef8bb
change log
michjnich Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ htmlcov
.tox
geckodriver.log
coverage.xml
.direnv/
.envrc
2 changes: 2 additions & 0 deletions debug_toolbar/static/debug_toolbar/css/toolbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,4 +734,6 @@
#djDebug[data-theme="dark"] #djToggleThemeButton svg.theme-dark,
#djDebug[data-theme="auto"] #djToggleThemeButton svg.theme-auto {
display: block;
height: 1rem;
width: 1rem;
}
6 changes: 0 additions & 6 deletions debug_toolbar/templates/debug_toolbar/includes/theme_selector.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
aria-hidden="true"
class="djdt-hidden theme-auto"
fill="currentColor"
width="1rem"
height="1rem"
viewBox="0 0 32 32"
version="1.1"
xmlns="http://www.w3.org/2000/svg"
Expand All @@ -15,8 +13,6 @@
<svg
aria-hidden="true"
class="djdt-hidden theme-light"
width="1rem"
height="1rem"
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
Expand All @@ -31,8 +27,6 @@
<svg
aria-hidden="true"
class="djdt-hidden theme-dark"
width="1rem"
height="1rem"
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
Expand Down
1 change: 1 addition & 0 deletions docs/changes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Pending
paths aren't installed.
* Introduce helper function ``debug_toolbar_urls`` to
simplify installation.
* Moved "1rem" height/width for SVGs to CSS properties.

4.4.2 (2024-05-27)
------------------
Expand Down