Fixed: Different JSON and XML behaviour #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a _build_json_doc method that strips keys with empty values from the doc prior to being serialized to JSON. This behaviour matches the behaviour of the XML method. It also uses the same method (_is_null_value) so if this behaviour needs to change in the future it should remain consistent. It includes a new test to ensure the behaviours of the two methods remain consistent. Fixes django-haystack#321
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 94.20% 94.31% +0.11%
==========================================
Files 7 7
Lines 1328 1338 +10
==========================================
+ Hits 1251 1262 +11
+ Misses 77 76 -1
Continue to review full report at Codecov.
|
acdha
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a _build_json_doc method that strips keys with empty values from the doc prior to being serialized to JSON. This behaviour matches the behaviour of the XML method. It also uses the same method (_is_null_value) so if this behaviour needs to change in the future it should remain consistent.
It includes a new test to ensure the behaviours of the two methods remain consistent.
Fixes #321