updated /content/plugins/module-concatenation-plugin.md(#377) #379

TyreeZhao · 2017-10-11T02:21:29Z

describe your changes...

Read and sign the CLA. PRs that haven't signed it won't be accepted.
Make sure your PR complies with the writer's guide.
Review the diff carefully as sometimes this can reveal issues.
Remove these instructions from your PR as they are for your eyes only.

dear-lizhihua · 2017-10-11T04:39:56Z

有冲突，你得合并下上游的更新

TyreeZhao · 2017-10-11T05:15:35Z

@dear-lizhihua 好了

捆绑失败优化 => 捆绑失败的优化

aladdin-add · 2017-10-12T09:51:48Z

src/content/plugins/module-concatenation-plugin.md


-As the article explains, webpack attempts to achieve partial scope hoisting. It will merge modules into a single scope but cannot do so in every case. If webpack cannot merge a module, the two alternatives are Prevent and Root. Prevent means the module must be in its own scope. Root means a new module group will be created. The following conditions determine the outcome:
+像文章中解释的， webpack 试图达到分批的作用域提升(scope hoisting)。它会将一些模型捆绑到一个作用域内，但并不是任何情况下都会这么做。如果 webpack 不能捆绑模型，将会有两个选择 `Prevent` 和 `Root`，`Prevent` 意思是模型必须在自己的作用域内。 `Root` 意思是一个新的模型组将被创建。以下情况决定了输出选择。


模型 => 模块

Nits: 捆绑=> 绑定

aladdin-add · 2017-10-12T09:52:35Z

src/content/plugins/module-concatenation-plugin.md

@@ -36,9 +36,9 @@ In Multiple Chunks                            | Prevent
 `export * from "cjs-module"`                  | Prevent


-### Module Grouping Algorithm
+### 模型组算法[Module Grouping Algorithm]


模块分组算法。

模型 => 模块捆绑=> 绑定

TyreeZhao · 2017-10-13T06:24:49Z

@aladdin-add fixed

dear-lizhihua · 2017-10-15T06:10:17Z

src/content/plugins/module-concatenation-plugin.md


-As the article explains, webpack attempts to achieve partial scope hoisting. It will merge modules into a single scope but cannot do so in every case. If webpack cannot merge a module, the two alternatives are Prevent and Root. Prevent means the module must be in its own scope. Root means a new module group will be created. The following conditions determine the outcome:
+像文章中解释的， webpack 试图达到分批的作用域提升(scope hoisting)。它会将一些模块绑定到一个作用域内，但并不是任何情况下都会这么做。如果 webpack 不能绑定模块，将会有两个选择 `Prevent` 和 `Root`，`Prevent` 意思是模块必须在自己的作用域内。 `Root` 意思是一个新的模块组将被创建。以下情况决定了输出选择。


这篇里，merge 是翻译成绑定吗？

Prevent 和 Root 不需要加 ``，尽量与原文标点保持一致。

意思是一个新的模块组将被创建 -> 意味着将创建一个新的模块组
以下情况决定了输出选择。 -> 以下条件决定了输出结果：

嗯，个人感觉 “捆绑” 比 “合并” 意思更合适

dear-lizhihua · 2017-10-15T06:14:05Z

src/content/plugins/module-concatenation-plugin.md


-The following pseudo JavaScript explains the algorithm:
+下面的 JS 解释了算法：


JS -> JavaScript，与原文保持一致

下面的 JS 解释了算法 -> 以下 JavaScript 伪代码解释了算法

dear-lizhihua · 2017-10-15T06:14:31Z

src/content/plugins/module-concatenation-plugin.md

@@ -80,10 +80,9 @@ function tryToAdd(group, module) {
 }
 ```

+### 优化绑定失败的调试[Debugging Optimization Bailouts]


这里行数不对应，少了一个空行

dear-lizhihua · 2017-10-15T06:16:06Z

src/content/plugins/module-concatenation-plugin.md

-### Debugging Optimization Bailouts
-
-When using the webpack CLI, the `--display-optimization-bailout` flag will display bailout reasons. When using the webpack config, just add the following to the `stats` object:
+当我们使用 webpack CLI 时，参数 `--display-optimization-bailout` 将显示绑定失败的原因。在 webpack 配置里，加上下面的 `stats` 对象:


加上下面的 stats 对象: -> 只需将以下内容添加到 stats 对象中：

zhaotongmeican and others added 10 commits September 28, 2017 16:44

translated ModuleConcatenationPlugin

a3e89ac

formate

751232a

added spaces.

f377a5c

formate

5f39c74

code review

c219f30

optimized

d9d2af5

updated

51c0e31

updated

6b7474c

Update module-concatenation-plugin.md

2e88926

updated /content/plugins/module-concatenation-plugin.md(docschina#377)

a183b4c

dear-lizhihua requested review from aladdin-add and dear-lizhihua October 11, 2017 04:39

Merge branch 'cn' into cn

697d885

TyreeZhao added 2 commits October 11, 2017 00:42

improved

4ab998a

捆绑失败优化 => 捆绑失败的优化

scope: 范围 => 作用域

ae3d955

aladdin-add suggested changes Oct 12, 2017

View reviewed changes

updated

c8a1474

模型 => 模块捆绑=> 绑定

dear-lizhihua reviewed Oct 15, 2017

View reviewed changes

trans review

f058b11

dear-lizhihua approved these changes Oct 15, 2017

View reviewed changes

Update module-concatenation-plugin.md

02d2b7f

aladdin-add approved these changes Oct 18, 2017

View reviewed changes

aladdin-add merged commit 08f324f into docschina:cn Oct 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

updated /content/plugins/module-concatenation-plugin.md(#377) #379

updated /content/plugins/module-concatenation-plugin.md(#377) #379

Uh oh!

TyreeZhao commented Oct 11, 2017 •

edited

Loading

Uh oh!

dear-lizhihua commented Oct 11, 2017 •

edited

Loading

Uh oh!

TyreeZhao commented Oct 11, 2017

Uh oh!

aladdin-add Oct 12, 2017

Uh oh!

aladdin-add Oct 12, 2017

Uh oh!

aladdin-add Oct 12, 2017

Uh oh!

TyreeZhao commented Oct 13, 2017

Uh oh!

dear-lizhihua Oct 15, 2017

Uh oh!

dear-lizhihua Oct 15, 2017

Uh oh!

dear-lizhihua Oct 15, 2017

Uh oh!

TyreeZhao Oct 15, 2017

Uh oh!

dear-lizhihua Oct 15, 2017

Uh oh!

dear-lizhihua Oct 15, 2017

Uh oh!

dear-lizhihua Oct 15, 2017

Uh oh!

Uh oh!


		As the article explains, webpack attempts to achieve partial scope hoisting. It will merge modules into a single scope but cannot do so in every case. If webpack cannot merge a module, the two alternatives are Prevent and Root. Prevent means the module must be in its own scope. Root means a new module group will be created. The following conditions determine the outcome:
		像文章中解释的， webpack 试图达到分批的作用域提升(scope hoisting)。它会将一些模型捆绑到一个作用域内，但并不是任何情况下都会这么做。如果 webpack 不能捆绑模型，将会有两个选择 `Prevent` 和 `Root`，`Prevent` 意思是模型必须在自己的作用域内。 `Root` 意思是一个新的模型组将被创建。以下情况决定了输出选择。


		The following pseudo JavaScript explains the algorithm:
		下面的 JS 解释了算法：

updated /content/plugins/module-concatenation-plugin.md(#377) #379

updated /content/plugins/module-concatenation-plugin.md(#377) #379

Uh oh!

Conversation

TyreeZhao commented Oct 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dear-lizhihua commented Oct 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TyreeZhao commented Oct 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TyreeZhao commented Oct 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TyreeZhao commented Oct 11, 2017 •

edited

Loading

dear-lizhihua commented Oct 11, 2017 •

edited

Loading