-
Notifications
You must be signed in to change notification settings - Fork 231
[Encryption] Improve diagnostic command #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GromNaN
wants to merge
18
commits into
doctrine:feature/queryable-encryption
Choose a base branch
from
GromNaN:improve-diagnostic-command
base: feature/queryable-encryption
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b7fcab0
Squashed commit of the following:
alcaeus 4b4e5e6
Extract encryption diagnostic to separate class
alcaeus 4ac845b
Extract connection diagnostics into separate print method
alcaeus 509c2f4
Add command to dump encrypted fields map
alcaeus cf0d366
Fix CS and static analysis
GromNaN 353bb5a
Fix DIC and mark diagnostic classes as internal
GromNaN 48ce7b0
Run CI
GromNaN f97c1c1
Catch runtime exception when mongocryptd is not running
GromNaN 9e5416f
Always print diagnostic for every connection, even if one is not OK
GromNaN 7e9a2d3
Remove duplicate service definition for diagnostic per connection
GromNaN 2e58e41
Add test to diagnostic command
GromNaN 3065c46
Add json format to the dump command
GromNaN 627fe52
Improve encrypted fields map docs
GromNaN 5c3e66d
Fix CS
GromNaN 32697ff
Skip server check when auto encryption is not enabled
GromNaN e192526
Add cryptSharedLibPath docs
GromNaN 04075c6
Update test to not dependents on mongocryptd availability
GromNaN cd2a184
Fix mongo_crypt_v1.so name
GromNaN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ on: | |
push: | ||
branches: | ||
- "*.x" | ||
- "feature/*" | ||
paths: | ||
- "composer.json" | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
is
afterthis setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.