Avoid latest version of phpunit mock object

[greg0ire]

That way, people can still work on their PR until the build is fixed.

Workaround for #2475 (not a proper fix)

[Ocramius]

What is the issue leading to this? createMock?

[greg0ire]

Not sure yet… in Sonata we use getMock, and have this problem too.

[Ocramius]

getMock will not work with PHPUnit 5.4+ (deprecation errors all over the place). The solution is to replace the calls with createMock calls

[greg0ire]

getMock will not work with PHPUnit 5.4+ (deprecation errors all over the place). The solution is to replace the calls with createMock calls

I think it is a different issues : these are php warnings, not phpunit warnings.

[greg0ire]

In Sonata it came from the fact we did not use getMock properly (not using FQCN, misspelling stdClass)

[greg0ire]

not using FQCN

Which seems to be the problem too in the case of this lib, see https://github.com/doctrine/dbal/blob/master/tests/Doctrine/Tests/DBAL/ConnectionTest.php#L105 , for instance.

Related issue : sebastianbergmann/phpunit-mock-objects#321

[Ocramius]

Then let's fix the test rather than blocking the dep (which will lead to more issues down the line)

[greg0ire]

I don't have the time right now, that's why I'm suggesting this temporary workaround, but sure, the tests (plural, that's why I think it will be long) have to be fixed properly and the commit in this PR reverted. Meanwhile, having green builds will allow other contributions to be merged (like #2473 , which I wrote this morning).

[greg0ire]

I can commit to fix it properly one evening this week though.

[Ocramius]

Closing here meanwhile then. Sorry, workarounds are not something that I will merge, unless we are really cornered inside a tight solution space.

[Ocramius]

@greg0ire thanks if you can submit further patches though!

[greg0ire]

No problem, I understand. I should be able to fix that properly tomorrow night