Skip to content

Rename "Individual User Accounts" to "Individual Accounts" #35523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 28, 2025

Conversation

timdeschryver
Copy link
Contributor

@timdeschryver timdeschryver commented May 24, 2025

Fixes #31137

  • first commit: copy pastes the current page into an include page, and createss a moniker for aspnet >= 8.0
  • second commit: renames "Individual User Accounts" to "Individual Accounts"
  • third commit: also updates other pages to use the updated wording. However, some of the monikers are for ASP.NET 6. If desired, I can revert these changes or also update the monikers.

Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
aspnetcore/blazor/security/webassembly/hosted-with-identity-server.md aspnetcore/blazor/security/webassembly/hosted-with-identity-server
aspnetcore/blazor/security/webassembly/standalone-with-authentication-library.md aspnetcore/blazor/security/webassembly/standalone-with-authentication-library
aspnetcore/fundamentals/dependency-injection.md aspnetcore/fundamentals/dependency-injection
aspnetcore/mvc/controllers/areas.md aspnetcore/mvc/controllers/areas
aspnetcore/mvc/views/razor.md aspnetcore/mvc/views/razor
aspnetcore/mvc/views/working-with-forms.md aspnetcore/mvc/views/working-with-forms
aspnetcore/security/app-secrets.md aspnetcore/security/app-secrets
aspnetcore/security/authentication/2fa.md aspnetcore/security/authentication/2fa
aspnetcore/security/authentication/customize-identity-model.md aspnetcore/security/authentication/customize-identity-model
aspnetcore/security/authentication/identity-custom-storage-providers.md aspnetcore/security/authentication/identity-custom-storage-providers
aspnetcore/security/authentication/identity.md aspnetcore/security/authentication/identity
aspnetcore/security/authentication/individual.md aspnetcore/security/authentication/individual
aspnetcore/security/authorization/secure-data.md aspnetcore/security/authorization/secure-data

@timdeschryver timdeschryver requested a review from guardrex as a code owner May 24, 2025 19:25
@guardrex
Copy link
Collaborator

Hi @timdeschryver ... I assume that this can wait until Tuesday morning, correct? I'm on a much needed three-day holiday weekend 🏖️.

@guardrex guardrex self-assigned this May 24, 2025
@timdeschryver
Copy link
Contributor Author

@guardrex totally, there's no need to do this now (as with any other PRs that I create). Feel free to review when you have the time. Thanks in advance, and enjoy your long weekend 🌞

@guardrex
Copy link
Collaborator

guardrex commented May 27, 2025

.... and we're BACK! 😄

This looks great except for a couple of super NITs that we can discuss in a minute. The more pressing problem are the sample cross-link breaks on the build report 😈. We'll need to see what the build system is choking on here.

@guardrex
Copy link
Collaborator

guardrex commented May 27, 2025

For starters, you might want to move identity6.md to a new folder at aspnetcore/security/authentication/identity/includes. I think that's the pattern typically adopted because it places the INCLUDE files SxS with a folder named like the article. This approach to sample versioning isn't what I use for Blazor, and I'm not too keen on it. IMO, it's harder to set up and maintain. Anyway, I don't think the team is up for a full repo-wide changeover to the original sample app plan from the Scott Addie Days™ 😆, which is what I use for Blazor samples. I recommend starting by repositioning that file. Then, deal with the relative address of the sample app in the cross-links to clear the build warnings.

After the INCLUDE and cross-linking is resolved, I'll go over a handful of super NIT changes that we probably should make here to wrap this up.

@guardrex
Copy link
Collaborator

Almost there ... id instead of name should fix those up.

@timdeschryver
Copy link
Contributor Author

You're faster than light @guardrex.
Welcome back and thanks for your review.

For the future I will try to not push as much, before testing it locally.

@guardrex
Copy link
Collaborator

No worries ... I have to do that all the time because so many little 😈 pop up during PR work.

@guardrex
Copy link
Collaborator

🎉

@wadepickett ... There are two build report warnings that look like map to one of your articles.

Stand-by @timdeschryver ... I'll list a few final 😈 to stomp out here.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the super NITs are so super-NITTY that they aren't worth addressing for this. I think the article could get a pass at some point in the future to make some small improvements here and there.

I'm good! I'll add Wade to take a look. Thanks @timdeschryver for sending this in. 🎸

@guardrex guardrex requested a review from wadepickett May 27, 2025 14:46
@dotnet-policy-service dotnet-policy-service bot requested a review from guardrex May 27, 2025 23:59
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @timdeschryver!

@wadepickett
Copy link
Contributor

@wadepickett ... There are two build report warnings that look like map to one of your articles.
@guardrex, I will fix in a different PR. Thanks for spotting that issue.

@wadepickett wadepickett merged commit 6b8c008 into dotnet:main May 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual User Accounts now "Individual Accounts"
3 participants