-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Rename "Individual User Accounts" to "Individual Accounts" #35523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @timdeschryver ... I assume that this can wait until Tuesday morning, correct? I'm on a much needed three-day holiday weekend 🏖️. |
@guardrex totally, there's no need to do this now (as with any other PRs that I create). Feel free to review when you have the time. Thanks in advance, and enjoy your long weekend 🌞 |
.... and we're BACK! 😄 This looks great except for a couple of super NITs that we can discuss in a minute. The more pressing problem are the sample cross-link breaks on the build report 😈. We'll need to see what the build system is choking on here. |
For starters, you might want to move After the INCLUDE and cross-linking is resolved, I'll go over a handful of super NIT changes that we probably should make here to wrap this up. |
Almost there ... |
You're faster than light @guardrex. For the future I will try to not push as much, before testing it locally. |
No worries ... I have to do that all the time because so many little 😈 pop up during PR work. |
🎉@wadepickett ... There are two build report warnings that look like map to one of your articles. Stand-by @timdeschryver ... I'll list a few final 😈 to stomp out here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the super NITs are so super-NITTY that they aren't worth addressing for this. I think the article could get a pass at some point in the future to make some small improvements here and there.
I'm good! I'll add Wade to take a look. Thanks @timdeschryver for sending this in. 🎸
Just updated ms.date
Udpated ms.date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @timdeschryver!
|
Fixes #31137
Internal previews
Toggle expand/collapse