Allow ArgumentsSource to reference methods in other types #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe do the same thing for |
|
Makes sense. Pushed! |
|
Can you also please add or update integration tests? |
|
I'm having trouble grokking the tests in this repo. I could use some help. Where would be the appropriate place for the new/modified tests? I can't find any existing tests that involve |
|
Thanks very much. Added two new tests to verify the newly-added behavior. All tests are passing locally. Edit: and I see they're also passing on the CI, nice |
timcassell
reviewed
Jun 5, 2025
timcassell
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2744
I added a new constructor for
ArgumentsSourceAttributewhich takes a custom type. I implemented the logic inBenchmarkConverterso that the custom type can be used. The behavior of the existing constructor is preserved.I updated the docs to explain the new feature.
I renamed a few internal method parameters for clarity.
This is my first contribution to BenchmarkDotNet. Please let me know if I did anything wrong!