[3.0] COM Binding Transformation #2406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Perksey Ready for Review |
Perksey
reviewed
Jan 12, 2025
sources/Win32/Win32/DirectX/d3d12/d3dcommon/ID3DDestructionNotifier.gen.cs
Outdated
Show resolved
Hide resolved
|
Obviously note the CI errors as well if you haven't already. |
Perksey
reviewed
Jan 15, 2025
sources/Win32/Win32/DirectX/d3d12/d3dcommon/D3D_CBUFFER_TYPE.gen.cs
Outdated
Show resolved
Hide resolved
curin
commented
Feb 8, 2025
Perksey
requested changes
Feb 8, 2025
-also support for csv lists in --only and --skip
-Setup to run using new mod system properly -Added pointer member accessor to member accessor conversion -Added Logging
per Mod Performance
-Added early out -fix duplicate call -Add INativeGuid
-fixed some broken using from TerraFX files -Allowed BaseType to be specified for ComTypes -Added several files for override due to issue in generation
-allowed for multiple COM base types -allowed for addition of manual COM types -added several manual overrides -added all manual files necessary for compilation
Fixed some manual warnings as well
This reverts commit 0a1bd47.
-using globbing instead of regex -removed an unnecessary restriction on interface finding -updates single line code to expression bodies
Co-authored-by: Dylan Perks <[email protected]>
for rollback purposes
moved to internal Native struct INativeInterface and IComInterface added to represent all interfaces and Com interfaces, respectively. - IComInterface is a child of INativeInterface and INativeGuid
-and fixing issues with how it works
added manual file importer added a progress bar in some cases for QoL moved rename function into NameUtils
Added per job file logs fixed up the progress bar system to be cleaner
This reverts commit ed1c763.
curin
force-pushed
the
develop/3/com-bindings-refactor
branch
from
6c6d633 to
fe2f36c
Compare
Also split some common classes out into core
Benefit of the doubt is expected and will now be accounted for
also fix for CI issues
Perksey
requested changes
Mar 13, 2025
There was a problem hiding this comment.
I'm really getting excited at this point now, and really happy with the progress on this PR. Yes I know there's 30 comments, but most of these are fairly small (in my opinion) and don't call into question conceptual/large ways of doing things as previous reviews have. Thanks for keeping with it!
Co-authored-by: Dylan Perks <[email protected]>
added prettify names handled renaming HString and HResult properly Added injected name remapping for clang scrapper Added injected generator options for clang scrapper
also set warnings as error back to true
Bool -> MaybeBool<int> Keep UnmanagedCallersOnly attributes Mark JobContext as Experimental Removed unnecessary warning disable from tests
- made both JobContext and ProgressService internal - Added missing HResult functions
Perksey
requested changes
Jun 11, 2025
There was a problem hiding this comment.
Running out of things to say tbh! Really great work. I know there's a lot of stuff that we can look at improving in the future, but this is a really great start and honestly I'm so chuffed at the idea of having full Windows SDK bindings in PREVIEW 1!!! (pending the next namespace change PR ofc)
-also uncomment HResult Manual whoops
Perksey
reviewed
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Adds the necessary enhancements to allow for easy to use COM bindings and any changes required to get Microsoft Bindings building.
-Adds TransformCOM mod to implement in place ComPtr transformations in all COM classes
-Adds DisableWarnings mod to disable warnings in all files for a job in order to avoid build errors from unavoidable or ignorable errors
-Adds several additions to ClangScraper to disable caching and remove generated files from the output.
-Adds some QOL improvements such as --only and csv list support to silk touch