[AOT] Failed to deploy app

[workgroupengineering]

Android application type

Classic Xamarin.Android (MonoAndroid12.0, etc.)

Affected platform version

VS 2022 17.1 Preview 5

Description

Unable to deploy the app

Steps to Reproduce

1. Clone Uno Repository
2. Rename crosstargeting_override.props.sample crosstargeting_override.props
3. Open crosstargeting_override.props
4. UnoTargetFrameworkOverride and set MonoAndroid12.0
5. Open Uno.UI-Android-only.slnf
6. Set SampleApp.Droid as Startup application
7. Run debug

Did you find any workaround?

Add the following target to Directory.Build.props

<UsingTask TaskName="ShortPath"
             TaskFactory="CodeTaskFactory"
             AssemblyFile="$(MSBuildBinPath)\Microsoft.Build.Tasks.Core.dll"
             >
    <ParameterGroup>
      <LongPath ParameterType="System.String" Required="true" />
      <OutputPath ParameterType="System.String" Output="true" />
    </ParameterGroup>
    <Task>
      <Code Type="Class" Language="C#">
        <![CDATA[

    using System.Text;
    using System.Runtime.InteropServices;
    using Microsoft.Build.Framework;

    public class ShortPath : ITask
    {
        const int MAX_PATH = 255;

        [DllImport("kernel32.dll", CharSet = CharSet.Auto)]
        private static extern int GetShortPathName(
            [MarshalAs(UnmanagedType.LPTStr)]
         string path,
            [MarshalAs(UnmanagedType.LPTStr)]
         StringBuilder shortPath,
            int shortPathLength
            );

        private static string GetShortPath(string path)
        {
            var shortPath = new StringBuilder(MAX_PATH);
            GetShortPathName(path, shortPath, MAX_PATH);
            return shortPath.ToString();
        }

        [Required]
        public string LongPath { get; set; }

        public string OutputPath { get; set; }
        public IBuildEngine BuildEngine { get; set; }
        public ITaskHost HostObject { get; set; }

        public bool Execute()
        {
            OutputPath = GetShortPath(LongPath);
            return true;
        }
    }
        ]]>
      </Code>
    </Task>
  </UsingTask>

  <Target Name="Fix_AndroidNdkPath"
          BeforeTargets="_AndroidAot"
          Condition="'$(MSBuildVersion)' &gt;= '17.1'">
    <PropertyGroup>
      <_OriginalAndroidNdkDirectory>$(AndroidNdkDirectory)</_OriginalAndroidNdkDirectory>
    </PropertyGroup>
    <ShortPath LongPath="$(_OriginalAndroidNdkDirectory)">
      <Output TaskParameter="OutputPath" PropertyName="_AndroidNdkDirectory" />
    </ShortPath>
  </Target>

Relevant log output

[CC] "C:\Program Files (x86)\Android\android-sdk\ndk-bundle\toolchains\llvm\prebuilt\windows-x86_64\bin\armv7a-linux-androideabi16-clang.CMD" -c -D__ANDROID_API__=16 -DANDROID -o obj\Debug\120\bundles\armeabi-v7a\temp.o -I "C:\Program Files (x86)\Android\android-sdk\ndk-bundle\toolchains\llvm\prebuilt\windows-x86_64\sysroot\usr\include\arm-linux-androideabi" -I "C:\Program Files (x86)\Android\android-sdk\ndk-bundle\toolchains\llvm\prebuilt\windows-x86_64\sysroot\usr\include" obj\Debug\120\bundles\armeabi-v7a\temp.c
"C:\Program " is not recognized as an internal or external command,
  an executable program or batch file.

[jonathanpeppers]

@workgroupengineering I don't follow what you're trying to do with the custom MSBuild logic above.

Can you reproduce your problem in a self-contained Xamarin.Android sample? Is the problem it is not selecting your $(AndroidNdkDirectory)?

[workgroupengineering]

@workgroupengineering I don't follow what you're trying to do with the custom MSBuild logic above.
The logic is to remove spaces from the path by using the short path. It is a patch to be able to esuguire the app is not the solution.

Probably the following Task does not quote the path correctly and recognizes C:\Program as the program to run.

https://github.com/xamarin/xamarin-android/blob/8ac442519063bbbb8d4cc98321ef37162c3be435/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Legacy.targets#L729-L740

Can you reproduce your problem in a self-contained Xamarin.Android sample? Is the problem it is not selecting your $(AndroidNdkDirectory)?

No, How do it?

Most likely to correct just change the following code

https://github.com/xamarin/xamarin-android/blob/c96d9f496675d177687273fb20bc65f6e5dc73cd/src/Xamarin.Android.Build.Tasks/Tasks/MakeBundleNativeCodeExternal.cs#L268-L272

with

      string MkbundlePath => $"\"{Path.Combine (ToolPath, "mkbundle.exe")}\"";

[jonathanpeppers]

If you create a File->New Xamarin.Android project, and add the BundleAssemblies setting to the .csproj:

<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
  <BundleAssemblies>true</BundleAssemblies>

And build for Release, do you hit the same issue?

We've kind of deprecated this setting going forward, and it is not available in .NET 6. Can you give some details on why you're using it? Thanks!

[workgroupengineering]

I have the same problem. I have tried in others with MonoAndroid 11.0.
msbuild.zip

[jonathanpeppers]

@workgroupengineering do you need BundleAssemblies=true, can you just turn off that setting?

[workgroupengineering]

Hi, in this moment I can make it BundleAssemblies = false. But obviously not in the release phase for performance reason.

[jonathanpeppers]

@workgroupengineering BundleAssemblies=true would actually make your performance worse, so that is why I asked why you would use it. It might save your .apk size a little, by compressing your .dll files.

We replaced this feature with AndroidEnableAssemblyCompression=true, which is on by default, so you should just use that instead.

[dellis1972]

There is also the AndroidUseAssemblyStore feature which will pack all the assemblies into one blob.
See this for more info on how it works https://github.com/xamarin/xamarin-android/blob/main/Documentation/project-docs/AssemblyStores.md.

BundleAssemblies was used to pack all the assemblies into a .so file.

I suspect we should issue a warning that BundleAssemblies has been deprecated, and point users to use AndroidUseAssemblyStore instead. Which I think is now on by default for Release apps.