Workaround Xunit bug casting InlineData #43570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See xunit/xunit#2564 Workaround this issue by avoiding a cast between nullable numeric types.
ericstj
requested review from
Tratcher,
halter73,
BrennanConroy,
JamesNK and
Pilchie
as code owners
BrennanConroy
approved these changes
Aug 26, 2022
Tratcher
approved these changes
Aug 26, 2022
ghost
added this to the 
dougbu
added a commit
that referenced
this pull request
Aug 28, 2022
* Get newer xUnit packages
- move to `2.4.2` version of most xUnit packages
- we were slightly behind Arcade SDK here and newer version has some fixes
- _could_ reuse Arcade SDK's `$(XUnitVersion)`
- that would require moving e.g. `$(XUnitAssertVersion)` to (say) CSharp.Common.props
- VersionDefaults.props in SDK imports our Versions.props before setting its defaults
- react to nullability errors due to new annotations in this version
- move to XUnit.Abstractions `1.0.0`
- react to issues new analyzer finds
* Workaround Xunit bug casting InlineData (#43570)
See xunit/xunit#2564
Workaround this issue by avoiding a cast between nullable numeric types.
Co-authored-by: Eric StJohn <[email protected]>
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See xunit/xunit#2564
Workaround this issue by avoiding a cast between nullable numeric types.