Skip to content

Log registered IApiDescriptionProvider implementations on load #57318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

captainsafia
Copy link
Member

This PR adds support for logging discovered IApiDescriptionProvider instances in the ApiExplorer codepath.

This PR is a precursor to #57295 which supports the same via new public API.

Note: because we are not introducing new public API here support for logging is not lit up in the gRPC implementation unless AddEndpointsApiExplorer or AddApiExplorer have already been invoked in the application's setup.

@captainsafia captainsafia requested review from halter73, brunolins16 and a team as code owners August 13, 2024 18:39
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 13, 2024
@captainsafia captainsafia added feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc labels Aug 13, 2024
@captainsafia captainsafia merged commit 08b60af into main Aug 13, 2024
26 checks passed
@captainsafia captainsafia deleted the safia/iapidescriptionprovider-log branch August 13, 2024 22:53
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc1 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants