Skip to content

[release/9.0] Fixed devtools url used for debug with chrome and edge #61948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: release/9.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 15, 2025

Backport of #61813 to release/9.0

/cc @javiercn @Dona278

Fixed devtools url used for debug with chrome and edge

Description

Ensures the correct creation of the devtools url with proxy to use for debug with chrome and edge browser which recently changed how urls are returned from "localhost:9222/json".

Fixes #61559

Customer Impact

Fixes a debugging issue in "debug in browser" mode.
image

Regression?

  • Yes
  • No

The format of http://localhost:9222/json changed, instead of relative uri it contains an absolute one in new browser versions.

Risk

  • High
  • Medium
  • Low

It still supports the old way, just adds an additional fallback for cases of absolute paths.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@github-actions github-actions bot requested a review from a team as a code owner May 15, 2025 09:56
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone May 15, 2025
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 22, 2025
@Dona278
Copy link
Contributor

Dona278 commented May 22, 2025

@javiercn courtesy ping hoping that will be merged before next net9 release 🙏

@javiercn
Copy link
Member

@Dona278 I need to check if this is already in a public .NET 10.0 release.

We normally fix things first in a preview then backport the patch. It might take an extra patch cycle as that help us reduce risk. I have triggered the PR tests to make sure that it is ready when we decide to merge it, and I'll bring it up for consideration on the next patch cycle.

@javiercn
Copy link
Member

@ilonatommy were you looking at these same E2E test failures recently?

@lewing lewing requested a review from thaystg May 22, 2025 17:42
@thaystg
Copy link
Member

thaystg commented May 22, 2025

Will we backport to release/8.0?

@ilonatommy
Copy link
Member

ilonatommy commented May 23, 2025

@ilonatommy were you looking at these same E2E test failures recently?

yes, it got blocked on main

// [InlineData(true)] QuarantinedTest: https://github.com/dotnet/aspnetcore/issues/61882

@ilonatommy
Copy link
Member

/ba-g failure is known and not related

@ilonatommy ilonatommy removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 23, 2025
@ilonatommy
Copy link
Member

I see, branch protection was elevated only for main, in backports having review + Build Analysis green is not enough to merge.

@javiercn
Copy link
Member

/backport to release/8.0

Copy link
Contributor Author

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/15207479105

@javiercn
Copy link
Member

I'll leave the PR prepared, and we can make a decision

@lewing lewing added the Servicing-consider Shiproom approval is required for the issue label May 28, 2025
Copy link
Contributor

Hi @@github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Servicing-consider Shiproom approval is required for the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants