-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/9.0] Fixed devtools url used for debug with chrome and edge #61948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/9.0
Are you sure you want to change the base?
Conversation
@javiercn courtesy ping hoping that will be merged before next net9 release 🙏 |
@Dona278 I need to check if this is already in a public .NET 10.0 release. We normally fix things first in a preview then backport the patch. It might take an extra patch cycle as that help us reduce risk. I have triggered the PR tests to make sure that it is ready when we decide to merge it, and I'll bring it up for consideration on the next patch cycle. |
@ilonatommy were you looking at these same E2E test failures recently? |
Will we backport to release/8.0? |
yes, it got blocked on main Line 1312 in 5678f22
|
/ba-g failure is known and not related |
I see, branch protection was elevated only for main, in backports having review + Build Analysis green is not enough to merge. |
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/15207479105 |
I'll leave the PR prepared, and we can make a decision |
Hi @@github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Backport of #61813 to release/9.0
/cc @javiercn @Dona278
Fixed devtools url used for debug with chrome and edge
Description
Ensures the correct creation of the devtools url with proxy to use for debug with chrome and edge browser which recently changed how urls are returned from "localhost:9222/json".
Fixes #61559
Customer Impact
Fixes a debugging issue in "debug in browser" mode.

Regression?
The format of http://localhost:9222/json changed, instead of relative uri it contains an absolute one in new browser versions.
Risk
It still supports the old way, just adds an additional fallback for cases of absolute paths.
Verification
Packaging changes reviewed?