Skip to content

API diff between .NET 10 Preview 3 and .NET 10 Preview 4 #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025

Conversation

carlossanlop
Copy link
Contributor

Repo area owners:

Libraries area owners:

  • System.Collections @dotnet/area-system-collections
  • System.Diagnostics @dotnet/area-system-diagnostics
  • System.IO.Compression @dotnet/area-system-io-compression
  • System.Linq @dotnet/area-system-linq
  • System.Memory @dotnet/area-system-memory
  • System.Runtime @dotnet/area-system-runtime
  • System.Runtime.InteropServices @dotnet/interop-contrib
  • System.Runtime.Intrinsics @dotnet/area-system-runtime-intrinsics
  • System.Security.Cryptography @dotnet/area-system-security

New tool to generate diffs

If you see any bugs, or if you don't see any APIs that should've showed up, please let me know. Main differences with the old tool:

  • It uses Roslyn instead of Cci.
  • It has unit tests.
  • The files are being generated by assembly, not by namespace. So for example, you might find System.Runtime.CompilerServices under the System.Runtime file.
  • Events now show their add and remove accessors.
  • Might show some attributes that we weren't showing before in Api Diffs. Let me know if you don't want them shown and I'll exclude them.

@carlossanlop carlossanlop requested review from a team May 13, 2025 02:26
@carlossanlop carlossanlop self-assigned this May 13, 2025
@AaronRobinsonMSFT
Copy link
Member

System.Runtime.InteropServices LGTM

@@ -0,0 +1,23 @@
# System.Runtime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Runtime changes LGTM

CC. @dotnet/area-system-runtime

@@ -0,0 +1,71 @@
# System.Runtime.Intrinsics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Runtime.Intrinsics changes LGTM

CC. @dotnet/area-system-runtime-intrinsics

@tarekgh
Copy link
Member

tarekgh commented May 13, 2025

System.Diagnostics LGTM!

Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

winforms looks good

@ericstj
Copy link
Member

ericstj commented May 21, 2025

cc @jozkee -- merging this

Lots of errors from linter about length of lines - which should not apply for code blocks. I see past diffs were merged without fixing these.

@ericstj ericstj merged commit 247b82d into dotnet:main May 21, 2025
2 of 3 checks passed
}
public sealed class MessageBoxResult
{
+ public const System.Windows.MessageBoxResult Abort = 3;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem with indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants