Skip to content

Update configuration.md #23862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2021
Merged

Update configuration.md #23862

merged 2 commits into from
Apr 21, 2021

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Apr 21, 2021 •
edited
Loading

Summary

Hyperlink "App secrets" to relevant article.

Fixes #23859

Internal preview

✔️ Configuration in .NET

@IEvangelist IEvangelist requested a review from a team as a code owner April 21, 2021 12:39
@dotnet-bot dotnet-bot added this to the April 2021 milestone Apr 21, 2021
@IEvangelist IEvangelist self-assigned this Apr 21, 2021
@IEvangelist IEvangelist requested a review from tdykstra April 21, 2021 12:40
@Youssef1313
Copy link
Member

There is a build warning: xref-not-found

Status checker didn't fail and is reporting: "Event is not a pull request or payload action is undefined." due to a recent change in the yml file.

Youssef1313
Youssef1313 reviewed Apr 21, 2021
View reviewed changes
@gewarren
Copy link
Contributor

There is a build warning: xref-not-found

Status checker didn't fail and is reporting: "Event is not a pull request or payload action is undefined." due to a recent change in the yml file.

Thanks. Yes I'm waiting on a review for the PR that fixes it: dotnet/samples#4542

tdykstra
tdykstra approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the change suggested by @Youssef1313 is accepted.

@IEvangelist
Copy link
Member Author

There is a build warning: xref-not-found
Status checker didn't fail and is reporting: "Event is not a pull request or payload action is undefined." due to a recent change in the yml file.

Thanks. Yes I'm waiting on a review for the PR that fixes it: dotnet/samples#4542

Hi @gewarren - I just approved dotnet/samples#4542

@IEvangelist IEvangelist merged commit f7be53e into main Apr 21, 2021
@IEvangelist IEvangelist deleted the link-app-secrets branch April 21, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@tdykstra tdykstra tdykstra approved these changes

Assignees

@IEvangelist IEvangelist

Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
April 2021
Development

Successfully merging this pull request may close these issues.

Suggestion to hyperlink "App secrets" to relevant article
5 participants
@IEvangelist @Youssef1313 @gewarren @tdykstra @dotnet-bot